~ Forums of Enroth ~
Would you like to react to this message? Create an account in a few clicks or log in to continue.

~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» Immortal Realms: Vampire Wars (HoMM like game)
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Unknown_Hero 2020-09-18, 23:10

» They talked about fheroes2!
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby sirDranik 2020-09-13, 02:51

» GoG Homm2 vs fheroes2 comparison review
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby sirDranik 2020-09-11, 01:19

» Resurrection of fheroes2 with 0.8 version
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Tibor0803 2020-09-08, 06:32

» [Enhancement] Enhancement for the information displayed when the player right clicks on an object
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby sirDranik 2020-09-07, 20:45

» Free Heroes of Might and Magic II (fheroes2) General Announcements
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby ihhub 2020-09-05, 02:34

» [Enhancement] Enhancement for Scouting secondary skill
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Unknown_Hero 2020-09-03, 21:26

Poll
Global announcements should be:
Everlasting, 1 for each project.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar110%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 0% [ 0 ]
Temporary, when there is something new to announce.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar11100%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 100% [ 6 ]
Holalala... No idea where the Ultimate artifact is.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar110%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 0% [ 0 ]
Total Votes : 6
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW Map List: Work in progress
H3SW: Dwelling Development
Heroes III: The Succession Wars v0.8.1 Beta
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
Project Ironfist announcements
Introduce yourself
Welcome fellow Enrothians!

 

 [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)

Go down 
AuthorMessage
Unknown_Hero
Mage
Mage
Unknown_Hero

Messages : 724
Quality Points : 74
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2018-10-16, 23:49

This is valid for versions 1.3.0+ of July 23, 2018, October 9, 2018 and October 16, 2018.

Launch ironfist.exe 1.3.0+
Load _MapName.MX2
Move the hero to any location object

The lua script contains only this code:

Code:
function OnLocationVisit(type, x, y)
end

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Me8Ypg0
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 280
Quality Points : 45
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-01, 11:54

I've added a note to the documentation to indicate the return value is required.

Quote :

OnLocationVisit(type, x, y)

It is called when a player attempts to visit any game's special location that has an event associated to it. x, y is the position of the campfire on the world map. See the possible type-s in Locations.



Must return a boolean. Return true to indicate that the game should skip the normal event associated with this location, and false to indicate the game should perform the normal event associated with this location.



Note that both boarding and disembarking from a boat will trigger this event.

Back to top Go down
Unknown_Hero
Mage
Mage
Unknown_Hero

Messages : 724
Quality Points : 74
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 05:39

Is this a temporary solution?
This code works well in the official version 1.3.0.
Code:
function OnLocationVisit(type, x, y)
end
The problem appeared from the unofficial version "1.3.0+" of July 23, 2018 and is persistent for the unofficial versions "1.3.0+" of October 9, 2018 and October 16, 2018.
What has been changed to trigger this problem?
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 280
Quality Points : 45
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 17:13

Yes, we changed OnLocationVisit to require a boolean return value, indicating whether the game should cancel the default event behavior.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 280
Quality Points : 45
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 18:31

I've just committed a change so that OnLocationVisit will still work if you return nothing. Returning nothing is equivalent to returning false.
Back to top Go down
Unknown_Hero
Mage
Mage
Unknown_Hero

Messages : 724
Quality Points : 74
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-04, 07:38

That's exactly what I thought. It's much better and also simpler this way. Thank you very much for that. Very Happy
Back to top Go down
Sponsored content




[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)
Back to top 
Page 1 of 1

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Bug Reports-
Jump to: