~ Forums of Enroth ~
Would you like to react to this message? Create an account in a few clicks or log in to continue.

~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» Immortal Realms: Vampire Wars (HoMM like game)
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Unknown_Hero 2020-09-18, 23:10

» They talked about fheroes2!
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby sirDranik 2020-09-13, 02:51

» GoG Homm2 vs fheroes2 comparison review
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby sirDranik 2020-09-11, 01:19

» Resurrection of fheroes2 with 0.8 version
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Tibor0803 2020-09-08, 06:32

» [Enhancement] Enhancement for the information displayed when the player right clicks on an object
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby sirDranik 2020-09-07, 20:45

» Free Heroes of Might and Magic II (fheroes2) General Announcements
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby ihhub 2020-09-05, 02:34

» [Enhancement] Enhancement for Scouting secondary skill
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Unknown_Hero 2020-09-03, 21:26

Poll
Global announcements should be:
Everlasting, 1 for each project.
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar110%[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar12
 0% [ 0 ]
Temporary, when there is something new to announce.
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar11100%[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar12
 100% [ 6 ]
Holalala... No idea where the Ultimate artifact is.
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar110%[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar12
 0% [ 0 ]
Total Votes : 6
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW Map List: Work in progress
H3SW: Dwelling Development
Heroes III: The Succession Wars v0.8.1 Beta
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
Project Ironfist announcements
Introduce yourself
Welcome fellow Enrothians!

 

 [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"

Go down 
AuthorMessage
Unknown_Hero
Mage
Mage
Unknown_Hero

Messages : 724
Quality Points : 74
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2018-09-27, 00:00

I'm trying to understand how it works. Smile

On the Scripting Documentation page:

GetCurrentPlayer()
Returns a number (0-5) determining which player is active now.

GetHeroOwner(hero)
hero: The hero to get the owner of. (See, for example, GetHero).
Returns the owner of the given hero as an integer (0-5), or -1 if the hero is not owned by any player (i.e.: is or may become available for hire).

I did some tests.

This does not work:

Code:
function OnHeroMove(x, y)
  player = GetCurrentPlayer();
  if player == 0 then
    MessageBox("Player is 0.");
  elseif player == 1 then
    MessageBox("Player is 1.");
  end;
end

This works:

Code:
function OnHeroMove(x, y)
  hero = GetCurrentHero();
  owner = GetHeroOwner(hero);
  if owner == 0 then
    MessageBox("Owner is 0.");
  elseif owner == 1 then
    MessageBox("Owner is 1.");
  end;
end

This works:

Code:
function OnHeroMove(x, y)
  player = GetCurrentPlayer();
  gold = GetResource(player, RESOURCE_GOLD);
  gold = gold - 500;
  SetResource(player, RESOURCE_GOLD, gold);
  MessageBox("Player - 500 gold.");
end

This does not work:

Code:
function OnHeroMove(x, y)
  hero = GetCurrentHero();
  player = GetHeroOwner(hero);
  gold = GetResource(player, RESOURCE_GOLD);
  gold = gold - 500;
  SetResource(player, RESOURCE_GOLD, gold);
  MessageBox("Player - 500 gold.");
end

So, what is the difference between the two expressions and why it works in one case and not in the other? Is this normal?

It would be nice if someone could tell me. Very Happy
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 280
Quality Points : 45
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2018-12-31, 15:59

The reason is that GetCurrentPlayer returns a player object, while GetHeroOwner returns a number. So, the documentation is incorrect. GetCurrentPlayer().color or GetPlayerColor(GetCurrentPlayer()) should do what you want it to do. It looks like this is a change that occurred during the scripting overhaul to deep-binding.

I will make it so GetHeroOwner also returns a player object, and update the documentation of both.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 280
Quality Points : 45
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2019-01-01, 12:01

This has been done. Both examples now work using "player.color == 0" .
Back to top Go down
Unknown_Hero
Mage
Mage
Unknown_Hero

Messages : 724
Quality Points : 74
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2019-01-03, 07:06

Thanks for the explanation and the change. Smile
Back to top Go down
Sponsored content




[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"
Back to top 
Page 1 of 1

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Modding and Mapmaking-
Jump to: