[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?

Mage Messages : 780 Quality Points : 78 Registration Date : 2015-09-06

Is there a way to make the Advanced Message Box work like the Question Box?

I tried this, the one with Question Box works, but there is no picture.

Code:: hero = GetCurrentHero();
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = QuestionBox("Do you wish the Medal of Honor?");
  if result then
   GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

With Advanced Message Box, the picture is there but it does not work.

Code:: hero = GetCurrentHero();
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = AdvancedMessageBox("Do you wish the Medal of Honor?", 2, -1, -1, 7, ARTIFACT_MEDAL_OF_HONOR, -1, 0, -1, 0);
  if result then
   GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

Any ideas?

Pikeman Messages : 47 Quality Points : 6 Registration Date : 2018-02-27

Unknown_Hero wrote:

Is there a way to make the Advanced Message Box work like the Question Box?

I tried this, the one with Question Box works, but there is no picture.

Code:: hero = GetCurrentHero();
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = QuestionBox("Do you wish the Medal of Honor?");
  if result then
   GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

With Advanced Message Box, the picture is there but it does not work.

Code:: hero = GetCurrentHero();
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = AdvancedMessageBox("Do you wish the Medal of Honor?", 2, -1, -1, 7, ARTIFACT_MEDAL_OF_HONOR, -1, 0, -1, 0);
  if result then
   GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

Any ideas?

Looking through the code of Ironfist, I found this:

Code:: static int l_AdvancedMessageBox(lua_State *L) {
  const char* msg = luaL_checkstring(L, 1);
  int yesno = luaL_checkinteger(L, 2);
  int horizontal = luaL_checkinteger(L, 3);
  int vertical = luaL_checknumber(L, 4);
  int img1type = luaL_checknumber(L, 5);
  int img1arg = luaL_checknumber(L, 6);
  int img2type = luaL_checknumber(L, 7);
  int img2arg = luaL_checknumber(L, 8);
  int writeOr = luaL_checknumber(L, 9);
  int a10 = luaL_checknumber(L, 10);
  NormalDialog((char*)msg, (int)yesno, (int)horizontal, (int)vertical, (int)img1type, (int)img1arg, (int)img2type, (int)img2arg, (int)writeOr, (int)a10);
  return 0;
}

(You can find this in src\cpp\shared\scripting\funcs.cpp at lines 75 to 88)

This clearly means that the function always returns 0 and doesn't care about anything that is passed to it. The return value of NormalDialog(...) is neglected here.

You can also see in the file that for the QuestionBox it calls H2QuestionBox() (which is just a wrapper function of NormalDialog()) and it stores the result by calling lua_pushboolean()). So AdvancedMessageBox doesn't return anything.

Mage Messages : 780 Quality Points : 78 Registration Date : 2015-09-06

Okay, thanks for your discovery and explanation. Smile

I hope the Ironfist team will remedy this so that we can use the full potential of the Advanced Message Box.

I used your hint to display +1 for the hero's primary skills with the Advanced Message Box.

"Image subtypes (the number in the list represents the type for which the subtype applies)
...
25: 0-3 (Attack, Defense, Spell Power, Knowledge) (100-103 displays a +1 skill)"

I made a post about it in the related thread.

Master Modder Messages : 289 Quality Points : 47 Registration Date : 2014-12-27

DarkAtom: To clarify, "return 0" in a Lua callback actually means that it returns no values, not that it returns 0. Returning 0 would be "lua_pushinteger(L, 0)" or similar.

Pikeman Messages : 47 Quality Points : 6 Registration Date : 2018-02-27

I know that, but if the C++ function says: return 0; then you can push as many integers as you want on the lua stack, none of them will get passed. You need to push the integer and return 1, not 0, to return a value in lua.