~ Forums of Enroth ~
Would you like to react to this message? Create an account in a few clicks or log in to continue.

~ Forums of Enroth ~

The Enroth diehard fan community
 
HomeHome  Latest imagesLatest images  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» Songs of Conquest
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Blake01 2024-04-07, 15:14

» ...to XP run...
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby CATMAN 2024-03-30, 03:16

» WARNING - The dreaded moment is here: Heroes 6 servers shutting down
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Blake01 2024-03-29, 23:04

» Songs of Silence (HoMM like game)
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Blake01 2024-03-27, 16:52

» Heroes Orchestra's 5th Birthday concerts with Paul Romero
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby rrravyn 2024-03-23, 22:45

» fheroes2 General Announcements
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby sirDranik 2024-03-17, 23:35

» Photo Gallery
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitimeby Sir Albe 2024-03-07, 06:57

Poll
Global announcements should be:
Everlasting, 1 for each project.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar110%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 0% [ 0 ]
Temporary, when there is something new to announce.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar11100%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 100% [ 6 ]
Holalala... No idea where the Ultimate artifact is.
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar110%[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Redbar12
 0% [ 0 ]
Total Votes : 6
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
Introduce yourself
H3SW General Discussion
H3SW Map List: Work in progress
H3SW: Dwelling Development
Forum Admins Feed
The Floody Land
Enrothian Fan Art
Heroes III: The Succession Wars v0.8.1 Beta

 

 [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)

Go down 
2 posters
AuthorMessage
Unknown_Hero
Mage
Mage
Unknown_Hero


Messages : 778
Quality Points : 78
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2018-10-16, 23:49

This is valid for versions 1.3.0+ of July 23, 2018, October 9, 2018 and October 16, 2018.

Launch ironfist.exe 1.3.0+
Load _MapName.MX2
Move the hero to any location object

The lua script contains only this code:

Code:
function OnLocationVisit(type, x, y)
end

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Me8Ypg0
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani


Messages : 288
Quality Points : 47
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-01, 11:54

I've added a note to the documentation to indicate the return value is required.

Quote :

OnLocationVisit(type, x, y)

It is called when a player attempts to visit any game's special location that has an event associated to it. x, y is the position of the campfire on the world map. See the possible type-s in Locations.



Must return a boolean. Return true to indicate that the game should skip the normal event associated with this location, and false to indicate the game should perform the normal event associated with this location.



Note that both boarding and disembarking from a boat will trigger this event.

Back to top Go down
Unknown_Hero
Mage
Mage
Unknown_Hero


Messages : 778
Quality Points : 78
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 05:39

Is this a temporary solution?
This code works well in the official version 1.3.0.
Code:
function OnLocationVisit(type, x, y)
end
The problem appeared from the unofficial version "1.3.0+" of July 23, 2018 and is persistent for the unofficial versions "1.3.0+" of October 9, 2018 and October 16, 2018.
What has been changed to trigger this problem?
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani


Messages : 288
Quality Points : 47
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 17:13

Yes, we changed OnLocationVisit to require a boolean return value, indicating whether the game should cancel the default event behavior.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani


Messages : 288
Quality Points : 47
Registration Date : 2014-12-27

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-03, 18:31

I've just committed a change so that OnLocationVisit will still work if you return nothing. Returning nothing is equivalent to returning false.
Back to top Go down
Unknown_Hero
Mage
Mage
Unknown_Hero


Messages : 778
Quality Points : 78
Registration Date : 2015-09-06

[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime2019-01-04, 07:38

That's exactly what I thought. It's much better and also simpler this way. Thank you very much for that. Very Happy
Back to top Go down
Sponsored content





[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Empty
PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y) Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)
Back to top 
Page 1 of 1
 Similar topics
-
» [Ironfist ver 1.3.0] OnLocationVisit(type, x, y) and AI-controlled heroes
» [Ironfist ver 1.2.1+][Script System] OnLocationVisit(type, x, y)
» [Ironfist ver 1.3.0] What is the best compatibility setting for ironfist.exe?
» [Ironfist ver 1.2] Ironfist Editor - Where is my mouse?
» [Ironfist 1.3.0+] Another bug with SetNumGuildSpells()

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Bug Reports-
Jump to: