[Ironfist ver 1.3.0] Systematic crash

Launch Last Stand scenario.
Attack the castle.
As soon as the archers can play, shoot the zombies at the bottom of the screen (the fifth group from the top), this crashes the program.

Whenever a ranged creature shoot at a troop located in any hexagon of the last row (the one at the very bottom of the screen) the program crashes, this is systematic.
This is valid for the human player and for the AI player and even for the AI player against another IA player, or against neutral creatures.

Unknown_Hero wrote:

Whenever a ranged creature shoot at a troop located in any hexagon of the last row (the one at the very bottom of the screen) the program crashes, this is systematic.
This is valid for the human player and for the AI player and even for the AI player against another IA player, or against neutral creatures.

Ok, somehow, under some unknown circumstances, it works here.

Script
Map

It is basically a modified version of the Sorrow's End map where I test stuff. I wasn't able to make a save 'cause...game crashes.
First skip all the messages in the beginning and then attack the Ogres. Shoot the bottom-right Ogres with the archmagi and no crash takes place. At least not for me.

I tried you map with the archmagi and the game does not crash for me either.
Indeed, they are the only ones (magi and archmagi) not to use a sprite considered as a "projectile". Their shoot uses an animation in the form of a "ray" that does not use a "moving sprite" as in the case of a projectile. With all the other ranged shooters, the game crashes.

Unknown_Hero wrote:

This is valid for the human player and for the AI player and even for the AI player against another IA player, or against neutral creatures.

A clarification on this, I had a crash of the program after watching an AI player attack a troop of archers on the adventure map. I supposed, wrongly I think, that the crash was linked, but I do not think that the crash is related to this because the IA versus IA combats should be only calculations and so there should be no animation during the combats between AI players.
The crash takes place only when there are animations during the combat.

Another precision, the game only crashes in the windowed mode, in full screen mode, the game does not crash.

Unknown_Hero wrote:

Another precision, the game only crashes in the windowed mode, in full screen mode, the game does not crash.

I cannot run H2 in full-screen because I am using Windows 10. The only way I can is by hooking it up to DxWnd. But even under DxWnd it crashes when shooting there.

Maybe you can try this if you want to play in full screen mode.

Noted.

Ok, this seems interesting.
Map
Start the map as New Game -> Hot Seat -> 2 Players. Go and attack the Dragon City (it will take 2 turns, that's why you need hot seat). Skip turn with other player. Attack. Titans shoot the Black Dragons on the last row and no bug.

BUT...if you try the same thing to the trolls, the bug will crash the game.

Also, I tried placing some Nomads on the map to test if the game doesn't crash on 2-hex creatures, but it does.

Interesting, I also got the same result.
And I also had a crash in full screen mode during another test.

This is caused by an error computing projectile graphics in the original game. The original game did not experience this crash because their projectiles are small. In Ironfist, we changed some code to make way for larger projectiles, exposing this bug in the original game. I have committed a fix.

The reason you can shoot dragons is that they're very tall. Specifically, their center is at least 100 pixels from the bottom of the screen.

Darmani wrote:

This is caused by an error computing projectile graphics in the original game. The original game did not experience this crash because their projectiles are small. In Ironfist, we changed some code to make way for larger projectiles, exposing this bug in the original game. I have committed a fix.

The reason you can shoot dragons is that they're very tall. Specifically, their center is at least 100 pixels from the bottom of the screen.

Ok, thank you for fixing it. In which branch is the fix in the repository, though? I want to compile the project myself, but branch master doesn't appear to be fixed.

@Darmani
It's always interesting to know why it does not work, thank you for taking the time to explain it.

@DarkAtom
Maybe that's what you want: Fix crash when shooting projectile at creature in bottom row

Unknown_Hero wrote:

@Darmani
It's always interesting to know why it does not work, thank you for taking the time to explain it.

@DarkAtom
Maybe that's what you want: Fix crash when shooting projectile at creature in bottom row

Thank you, @Unknown Hero!