~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  FAQFAQ  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» [H3SW v0.8.0] Game not launching (Assert violation in file...) or lacking VCRUNTIME140.DLL
by Orzie Yesterday at 20:21

» Cartographers' Guild
by dodge 2019-01-18, 18:02

» Is H3:SW 0.8 stable without using HD mod
by badlemon 2019-01-18, 06:05

» Heroes III: The Succession Wars v0.8.0 Beta
by badlemon 2019-01-16, 09:36

» [EIP=0x59174188] Crash at start of the game
by Orzie 2019-01-16, 07:14

» [EIP=0x00426020] Crash During Enemy AI Turn - Division By 0
by Orzie 2019-01-16, 05:55

» Forum Admins Feed
by GodRage 2019-01-16, 02:26

Poll
"Wait" in HoMM2?
Yes
80%
 80% [ 55 ]
No
20%
 20% [ 14 ]
Total Votes : 69
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW: Dwelling Development
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
H3SW Map List: Work in progress
Welcome fellow Enrothians!
Enrothian Fan Art
Commanders?
H3SW Recruitment Point - Enroth Needs You!

Share | 
 

 [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()

Go down 
AuthorMessage
Unknown_Hero
Vampire
Vampire
avatar

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2018-12-22, 05:13

Try this code:

Code:
function OnBattleStart()
  hero = BattleGetHero(0);
  quantity = 10;
  SetPrimarySkill(hero, PRIMARY_SKILL_ATTACK, quantity);
  SetPrimarySkill(hero, PRIMARY_SKILL_DEFENSE, quantity);
end

The hero's attack and defense skills are properly updated, but creatures do not fully benefit from the hero's attack and defense bonuses.



Back to top Go down
DarkAtom
Pikeman
Pikeman
avatar

Messages : 32
Quality Points : 2
Registration Date : 2018-02-27

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2018-12-27, 04:45

I don't think that is a bug from Ironfist, the game is just not supposed to modify creature stats in battle. In the Heroes III WOG scripting documentation, it is stated that changing the hero's stats in a battle makes no sense, as no creature/spell will benefit from it. I guess Heroes II works the same way.
Back to top Go down
Unknown_Hero
Vampire
Vampire
avatar

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2018-12-27, 05:27

Yes, it's not a bug, but as I said it's more of a problem. I think having the ability to update different creature-related values directly during combat would really be a plus. For example with "UpdateAllCreaturesAttack", "UpdateAllCreaturesDefense", "UpdateAllCreaturesSpeed", etc. or/and "Get/Set...Stack...Attack/Defense/etc.".
I think that should be possible to add these expressions to Ironfist because it is already possible to modify these values with the spells.


Last edited by Unknown_Hero on 2019-01-04, 07:41; edited 1 time in total
Back to top Go down
Darmani
Master Modder
Master Modder
avatar

Messages : 237
Quality Points : 38
Registration Date : 2014-12-27

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2018-12-31, 16:20

You can already modify creature's stats during combat. However, it looks like we've only made it possible to change their quantity. I'll get on this ASAP.
Back to top Go down
Unknown_Hero
Vampire
Vampire
avatar

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2019-01-03, 04:00

Very nice, thanks. Smile
Back to top Go down
Darmani
Master Modder
Master Modder
avatar

Messages : 237
Quality Points : 38
Registration Date : 2014-12-27

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2019-01-04, 18:44

I have added 10 new scripting functions to get/set a stack's attack, defense, speed, HP, and shots.
Back to top Go down
Unknown_Hero
Vampire
Vampire
avatar

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   2019-01-05, 04:41

Oh, that's really good. Smile
I will already use some of them when I adapt the current Unknonw Mod script for the next official version of Ironfist.
I already have code in the Unknonw Mod script for the official version 1.3.0 but the results are not perfect.
These additions will help me a lot in the realization of some ideas for the script and it will also be much easier with these additions. Thank you very much for that. Very Happy
Back to top Go down
Sponsored content




PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   

Back to top Go down
 
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()
Back to top 
Page 1 of 1
 Similar topics
-
» Webmail problem
» Problem uploading photos to Servimg on mobile device
» Text Color Problem
» xat chat code problem
» A bit of a strange problem...

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Bug Reports-
Jump to: