~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  FAQFAQ  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» Concernig Balance in H3SW
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Ctesiphon Yesterday at 23:00

» Creature stack experience like in Wake of Gods
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Sibernethy Yesterday at 19:09

» My review of H3SW
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Sir Albe Yesterday at 01:15

» The Floody Land
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Sir Albe Yesterday at 01:07

» [H3SW 0.8.1] Migration
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Ctesiphon 2019-06-13, 01:37

» Pixel painting: Mefista
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Mefista 2019-06-04, 06:36

» [H3SW 0.8.1] The Chain
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitimeby Ctesiphon 2019-06-03, 03:40

Poll
"Wait" in HoMM2?
Yes
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Redbar1180%[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Redbar12
 80% [ 55 ]
No
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Redbar1120%[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Redbar12
 20% [ 14 ]
Total Votes : 69
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW: Dwelling Development
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
H3SW Map List: Work in progress
Welcome fellow Enrothians!
Enrothian Fan Art
Commanders?
H3SW Recruitment Point - Enroth Needs You!

Share
 

 [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()

Go down 
AuthorMessage
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 467
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2018-12-22, 05:13

Try this code:

Code:
function OnBattleStart()
  hero = BattleGetHero(0);
  quantity = 10;
  SetPrimarySkill(hero, PRIMARY_SKILL_ATTACK, quantity);
  SetPrimarySkill(hero, PRIMARY_SKILL_DEFENSE, quantity);
end

The hero's attack and defense skills are properly updated, but creatures do not fully benefit from the hero's attack and defense bonuses.

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() NDl1KzA

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() ER7K9IA
Back to top Go down
DarkAtom
Pikeman
Pikeman
DarkAtom

Messages : 32
Quality Points : 2
Registration Date : 2018-02-27

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2018-12-27, 04:45

I don't think that is a bug from Ironfist, the game is just not supposed to modify creature stats in battle. In the Heroes III WOG scripting documentation, it is stated that changing the hero's stats in a battle makes no sense, as no creature/spell will benefit from it. I guess Heroes II works the same way.
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 467
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2018-12-27, 05:27

Yes, it's not a bug, but as I said it's more of a problem. I think having the ability to update different creature-related values directly during combat would really be a plus. For example with "UpdateAllCreaturesAttack", "UpdateAllCreaturesDefense", "UpdateAllCreaturesSpeed", etc. or/and "Get/Set...Stack...Attack/Defense/etc.".
I think that should be possible to add these expressions to Ironfist because it is already possible to modify these values with the spells.


Last edited by Unknown_Hero on 2019-01-04, 07:41; edited 1 time in total
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 239
Quality Points : 39
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2018-12-31, 16:20

You can already modify creature's stats during combat. However, it looks like we've only made it possible to change their quantity. I'll get on this ASAP.
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 467
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2019-01-03, 04:00

Very nice, thanks. Smile
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 239
Quality Points : 39
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2019-01-04, 18:44

I have added 10 new scripting functions to get/set a stack's attack, defense, speed, HP, and shots.
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 467
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime2019-01-05, 04:41

Oh, that's really good. Smile
I will already use some of them when I adapt the current Unknonw Mod script for the next official version of Ironfist.
I already have code in the Unknonw Mod script for the official version 1.3.0 but the results are not perfect.
These additions will help me a lot in the realization of some ideas for the script and it will also be much easier with these additions. Thank you very much for that. Very Happy
Back to top Go down
Sponsored content




[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Empty
PostSubject: Re: [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()   [Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart() Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0] Problem with SetPrimarySkill(hero, skill, quantity) and OnBattleStart()
Back to top 
Page 1 of 1

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Bug Reports-
Jump to: