~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  FAQFAQ  SearchSearch  RegisterRegister  Log inLog in  

Share | 
 

 [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)

Go down 
AuthorMessage
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2018-10-16, 23:49

This is valid for versions 1.3.0+ of July 23, 2018, October 9, 2018 and October 16, 2018.

Launch ironfist.exe 1.3.0+
Load _MapName.MX2
Move the hero to any location object

The lua script contains only this code:

Code:
function OnLocationVisit(type, x, y)
end

Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 237
Quality Points : 38
Registration Date : 2014-12-27

PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2019-01-01, 11:54

I've added a note to the documentation to indicate the return value is required.

Quote :

OnLocationVisit(type, x, y)

It is called when a player attempts to visit any game's special location that has an event associated to it. x, y is the position of the campfire on the world map. See the possible type-s in Locations.



Must return a boolean. Return true to indicate that the game should skip the normal event associated with this location, and false to indicate the game should perform the normal event associated with this location.



Note that both boarding and disembarking from a boat will trigger this event.

Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2019-01-03, 05:39

Is this a temporary solution?
This code works well in the official version 1.3.0.
Code:
function OnLocationVisit(type, x, y)
end
The problem appeared from the unofficial version "1.3.0+" of July 23, 2018 and is persistent for the unofficial versions "1.3.0+" of October 9, 2018 and October 16, 2018.
What has been changed to trigger this problem?
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 237
Quality Points : 38
Registration Date : 2014-12-27

PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2019-01-03, 17:13

Yes, we changed OnLocationVisit to require a boolean return value, indicating whether the game should cancel the default event behavior.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 237
Quality Points : 38
Registration Date : 2014-12-27

PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2019-01-03, 18:31

I've just committed a change so that OnLocationVisit will still work if you return nothing. Returning nothing is equivalent to returning false.
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 459
Quality Points : 58
Registration Date : 2015-09-06

PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   2019-01-04, 07:38

That's exactly what I thought. It's much better and also simpler this way. Thank you very much for that. Very Happy
Back to top Go down
Sponsored content




PostSubject: Re: [Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)   

Back to top Go down
 
[Ironfist ver 1.3.0+] Bug with fonction OnLocationVisit(type, x, y)
Back to top 
Page 1 of 1
 Similar topics
-
» [Ironfist ver 1.2] scrXXXX.tmp files
» Some Ironfist changes I am working on
» [Ironfist ver 1.2] Crash with AUTOSAVE
» Diane Schuler Was Drunk and High at the Time of the Crash That Killed 8
» How to make this type of login pop up?

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Bug Reports-
Jump to: