~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  FAQFAQ  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» [H3SW 0.8.1] The Ultimate Mug of Ale
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Ctesiphon Today at 06:27

» Lands of Enroth 2018 & 2019
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby GodRage Today at 06:14

» Heroes of Might & Magic 2 Civilization 2 Mod!
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby GodRage Today at 05:15

» [H3SW 0.8.1] A Crossroad Tavern
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby GodRage Yesterday at 21:23

» [H3SW 0.8.1] Migration
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Ctesiphon Yesterday at 20:46

» play online
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby YhyJasne Yesterday at 09:30

» Lands of Enroth - Maps system
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitimeby Orzie Yesterday at 00:45

Poll
"Wait" in HoMM2?
Yes
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar1180%[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar12
 80% [ 55 ]
No
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar1120%[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Redbar12
 20% [ 14 ]
Total Votes : 69
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW: Dwelling Development
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
H3SW Map List: Work in progress
Welcome fellow Enrothians!
Heroes III: The Succession Wars v0.8.1 Beta
Enrothian Fan Art
Commanders?

Share
 

 [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"

Go down 
AuthorMessage
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 471
Quality Points : 63
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2018-09-27, 00:00

I'm trying to understand how it works. Smile

On the Scripting Documentation page:

GetCurrentPlayer()
Returns a number (0-5) determining which player is active now.

GetHeroOwner(hero)
hero: The hero to get the owner of. (See, for example, GetHero).
Returns the owner of the given hero as an integer (0-5), or -1 if the hero is not owned by any player (i.e.: is or may become available for hire).

I did some tests.

This does not work:

Code:
function OnHeroMove(x, y)
  player = GetCurrentPlayer();
  if player == 0 then
    MessageBox("Player is 0.");
  elseif player == 1 then
    MessageBox("Player is 1.");
  end;
end

This works:

Code:
function OnHeroMove(x, y)
  hero = GetCurrentHero();
  owner = GetHeroOwner(hero);
  if owner == 0 then
    MessageBox("Owner is 0.");
  elseif owner == 1 then
    MessageBox("Owner is 1.");
  end;
end

This works:

Code:
function OnHeroMove(x, y)
  player = GetCurrentPlayer();
  gold = GetResource(player, RESOURCE_GOLD);
  gold = gold - 500;
  SetResource(player, RESOURCE_GOLD, gold);
  MessageBox("Player - 500 gold.");
end

This does not work:

Code:
function OnHeroMove(x, y)
  hero = GetCurrentHero();
  player = GetHeroOwner(hero);
  gold = GetResource(player, RESOURCE_GOLD);
  gold = gold - 500;
  SetResource(player, RESOURCE_GOLD, gold);
  MessageBox("Player - 500 gold.");
end

So, what is the difference between the two expressions and why it works in one case and not in the other? Is this normal?

It would be nice if someone could tell me. Very Happy
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 244
Quality Points : 40
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2018-12-31, 15:59

The reason is that GetCurrentPlayer returns a player object, while GetHeroOwner returns a number. So, the documentation is incorrect. GetCurrentPlayer().color or GetPlayerColor(GetCurrentPlayer()) should do what you want it to do. It looks like this is a change that occurred during the scripting overhaul to deep-binding.

I will make it so GetHeroOwner also returns a player object, and update the documentation of both.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 244
Quality Points : 40
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2019-01-01, 12:01

This has been done. Both examples now work using "player.color == 0" .
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 471
Quality Points : 63
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime2019-01-03, 07:06

Thanks for the explanation and the change. Smile
Back to top Go down
Sponsored content




[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Empty
PostSubject: Re: [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"   [Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)" Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0] "GetCurrentPlayer()" and "GetHeroOwner(hero)"
Back to top 
Page 1 of 1
 Similar topics
-
» Some Ironfist changes I am working on
» My E-Hero deck

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Modding and Mapmaking-
Jump to: