~ Forums of Enroth ~

An Enroth diehard fan community
 
HomeHome  FAQFAQ  SearchSearch  RegisterRegister  Log inLog in  
Latest topics
» Project Ironfist announcements
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Unknown_Hero Today at 09:55

» Czech language
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Kattnienika Yesterday at 19:16

» Introduce yourself
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby GodRage 2019-05-24, 01:22

» [Unknown Mod] General Informations
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Unknown_Hero 2019-05-23, 06:17

» [Heroes 2 Bugs] Crash or/and View Puzzle map corrupted when visiting an obelisk
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Unknown_Hero 2019-05-18, 02:46

» Enroth's History & Stories
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Orzie 2019-05-13, 17:39

» [H3SW v0.8.1] Necromancer castles cause my game to crash (Sometimes)
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitimeby Orzie 2019-05-13, 17:22

Poll
"Wait" in HoMM2?
Yes
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Redbar1180%[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Redbar12
 80% [ 55 ]
No
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Redbar1120%[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Redbar12
 20% [ 14 ]
Total Votes : 69
Most Viewed Topics
H3SW: General Graphics discussion
Ragoon's Graphics For HoMM3SW
H3SW General Discussion
H3SW: Dwelling Development
Heroes of Might and Magic 3: The Succession Wars - General info & Announcements
H3SW Map List: Work in progress
Welcome fellow Enrothians!
Enrothian Fan Art
Commanders?
H3SW Recruitment Point - Enroth Needs You!

Share
 

 [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?

Go down 
AuthorMessage
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 465
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime2018-09-25, 22:26

Is there a way to make the Advanced Message Box work like the Question Box?

I tried this, the one with Question Box works, but there is no picture.

Code:
hero = GetCurrentHero();  
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = QuestionBox("Do you wish the Medal of Honor?");
  if result then
    GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

With Advanced Message Box, the picture is there but it does not work.

Code:
hero = GetCurrentHero();  
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = AdvancedMessageBox("Do you wish the Medal of Honor?", 2, -1, -1, 7, ARTIFACT_MEDAL_OF_HONOR, -1, 0, -1, 0);
  if result then
    GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

Any ideas?
Back to top Go down
DarkAtom
Pikeman
Pikeman
DarkAtom

Messages : 32
Quality Points : 2
Registration Date : 2018-02-27

[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: Re: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime2018-12-25, 05:29

Unknown_Hero wrote:
Is there a way to make the Advanced Message Box work like the Question Box?

I tried this, the one with Question Box works, but there is no picture.

Code:
hero = GetCurrentHero();  
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = QuestionBox("Do you wish the Medal of Honor?");
  if result then
    GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

With Advanced Message Box, the picture is there but it does not work.

Code:
hero = GetCurrentHero();  
if HasArtifact(hero, ARTIFACT_MEDAL_OF_HONOR) == false and CountEmptyArtifactSlots(hero) >= 1 then
  result = AdvancedMessageBox("Do you wish the Medal of Honor?", 2, -1, -1, 7, ARTIFACT_MEDAL_OF_HONOR, -1, 0, -1, 0);
  if result then
    GrantArtifact(hero, ARTIFACT_MEDAL_OF_HONOR);
  end;
end;

Any ideas?

Looking through the code of Ironfist, I found this:
Code:
static int l_AdvancedMessageBox(lua_State *L) {
  const char* msg = luaL_checkstring(L, 1);
  int yesno = luaL_checkinteger(L, 2);
  int horizontal = luaL_checkinteger(L, 3);
  int vertical = luaL_checknumber(L, 4);
  int img1type = luaL_checknumber(L, 5);
  int img1arg = luaL_checknumber(L, 6);
  int img2type = luaL_checknumber(L, 7);
  int img2arg = luaL_checknumber(L, 8);
  int writeOr = luaL_checknumber(L, 9);
  int a10 = luaL_checknumber(L, 10);
  NormalDialog((char*)msg, (int)yesno, (int)horizontal, (int)vertical, (int)img1type, (int)img1arg, (int)img2type, (int)img2arg, (int)writeOr, (int)a10);
  return 0;
}
(You can find this in src\cpp\shared\scripting\funcs.cpp at lines 75 to 88)

This clearly means that the function always returns 0 and doesn't care about anything that is passed to it. The return value of NormalDialog(...) is neglected here.

You can also see in the file that for the QuestionBox it calls H2QuestionBox()  (which is just a wrapper function of NormalDialog()) and it stores the result by calling lua_pushboolean()). So AdvancedMessageBox doesn't return anything.
Back to top Go down
Unknown_Hero
Vampire
Vampire
Unknown_Hero

Messages : 465
Quality Points : 60
Registration Date : 2015-09-06

[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: Re: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime2018-12-25, 08:08

Okay, thanks for your discovery and explanation. Smile
I hope the Ironfist team will remedy this so that we can use the full potential of the Advanced Message Box.

I used your hint to display +1 for the hero's primary skills with the Advanced Message Box.

"Image subtypes (the number in the list represents the type for which the subtype applies)
...
25: 0-3 (Attack, Defense, Spell Power, Knowledge) (100-103 displays a +1 skill)"

I made a post about it in the related thread.
Back to top Go down
Darmani
Master Modder
Master Modder
Darmani

Messages : 238
Quality Points : 38
Registration Date : 2014-12-27

[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: Re: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime2018-12-31, 15:49

DarkAtom: To clarify, "return 0" in a Lua callback actually means that it returns no values, not that it returns 0. Returning 0 would be "lua_pushinteger(L, 0)" or similar.
Back to top Go down
DarkAtom
Pikeman
Pikeman
DarkAtom

Messages : 32
Quality Points : 2
Registration Date : 2018-02-27

[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: Re: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime2019-01-02, 02:27

I know that, but if the C++ function says: return 0; then you can push as many integers as you want on the lua stack, none of them will get passed. You need to push the integer and return 1, not 0, to return a value in lua.
Back to top Go down
Sponsored content




[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Empty
PostSubject: Re: [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?   [Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"? Icon_minitime

Back to top Go down
 
[Ironfist ver 1.3.0] How to make "Advanced Message Box" work like "Question Box"?
Back to top 
Page 1 of 1

Permissions in this forum:You cannot reply to topics in this forum
~ Forums of Enroth ~ :: Modding Guild :: Heroes of Might and Magic II: Project Ironfist :: Modding and Mapmaking-
Jump to: